Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#365-enhancement-create-SubscriptionPage #407

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

JuliaAvramenko
Copy link
Collaborator

Сделала страницу подписки (SubscriptionPage) c адаптацией

@JuliaAvramenko JuliaAvramenko requested a review from aimenin June 10, 2024 12:09
@JuliaAvramenko JuliaAvramenko self-assigned this Jun 10, 2024
@JuliaAvramenko JuliaAvramenko added enhancement New feature or request верстка labels Jun 10, 2024
@JuliaAvramenko JuliaAvramenko linked an issue Jun 10, 2024 that may be closed by this pull request
Copy link
Collaborator

@aimenin aimenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Парочка замечаний

setIsModalClosing(true)
}

const links = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

выносим либо за компонент, либо оборачиваем в memo

{ label: 'Нет', value: 'Нет' }
]
function handleRedirectPrevious() {
//TODO
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

создаем issue для todo

const initialValues: IDistributionForm = {
subscription: String('Нет')
}
const subscription = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

констнты не храним в компоненте, выносим за компонент, либо useMemo

@aimenin aimenin self-requested a review June 14, 2024 04:18
Copy link
Collaborator

@aimenin aimenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отлично!

@aimenin aimenin merged commit f5ad827 into master Jun 25, 2024
1 check failed
@aimenin aimenin deleted the enhancement-365-create-SubscriptionPage branch June 25, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request верстка
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Блок подписка
2 participants