-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#365-enhancement-create-SubscriptionPage #407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Парочка замечаний
setIsModalClosing(true) | ||
} | ||
|
||
const links = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
выносим либо за компонент, либо оборачиваем в memo
{ label: 'Нет', value: 'Нет' } | ||
] | ||
function handleRedirectPrevious() { | ||
//TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
создаем issue для todo
const initialValues: IDistributionForm = { | ||
subscription: String('Нет') | ||
} | ||
const subscription = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
констнты не храним в компоненте, выносим за компонент, либо useMemo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Отлично!
Сделала страницу подписки (SubscriptionPage) c адаптацией