ViewedProductsSkeleton #421
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aimenin
requested changes
Jun 20, 2024
| margin:0; | ||
|
|
||
| & > *:not(:last-child) { | ||
| margin-bottom: 8px; |
There was a problem hiding this comment.
зачем нам нужен margin-bottom? Если это карточка лежит во flex контейнере - в этом контейнере используем css свойство gap
| {hasLabel && <span className={styles.viewedproducts__label}>Вы смотрели</span>} | ||
| </div> | ||
| <Scroll className={styles.viewedproducts__scroll} withManualGrip={true}> | ||
| {viewedProducts?.length !== 0 |
There was a problem hiding this comment.
если у нас не будет продуктов - всегда будут высвечиватся скелетон. Нужно посмотреть есть ли в redux поле с loading, если нет - то нужно его добавить и здесь ориентироваться на него
aimenin
requested changes
Jun 25, 2024
| isLoading: false | ||
| } | ||
|
|
||
| const loadingSlice = createSlice({ |
There was a problem hiding this comment.
мы не делаем отдельный слайс для загрузки, посмотри как сделано у Маргариты на странице категорий.
У нас уже есть слайс, откуда мы берем данные, там же будет и загрузка
| @@ -49,19 +54,41 @@ const ViewedProducts: FC<IViewedProductsProps> = ({ title, hasLabel }) => { | |||
| ) | |||
| }) | |||
|
|
|||
| useEffect(() => { | |||
| if (isLoading) { | |||
| const timer = setTimeout(() => { | |||
There was a problem hiding this comment.
это нам еще зачем?
Если у нас нет запроса к серверу - нам вообще не нужен скелетон
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Сделала скелетон в разделе "Наши предложения"
Высоту поставила ту же, что и в истории, карточки предложений почему-то не приходят
ссылка на задачу #309