[Dependency] Webpack to v5, istanbul removed #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thepiyush-303 Please uncommit your dist files per the README; thank you! |
|
@thepiyush-303 dist files are still listen in the files changed |
thepiyush-303
force-pushed
the
bump_webpack
branch
from
6a4857f
to
dfe5fbc
Compare
micpap25
changed the title
micpap25
changed the title
|
@thepiyush-303 your PR seems to be breaking, could you please address this? |
|
@micpap25 |
|
@thepiyush-303 the tests confirm that NPM can install and build the repository. So something is incorrect with your package.json configuration. Please confirm that it correctly installs on your machine before committing, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ved istanbul-instrument-loader
@micpap25
Hope it Helps.
Issue Submitty/Submitty#10641