Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that writes to GPIO extended writes both bank A and B (needed for OPL3 Express) #7

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

mywave82
Copy link
Contributor

As I am adding support for RetroWave OPL3 Express in adplay-unix I noticed that resetting the OPL3 IC didn't work.

If I added that we write to GPIOB aswell as GPIOA register, it started to work. I assume that the firmware that emulates MCP23S17 latches the MCU GPIO pins on every even data received, probably to ensure bus-timing.

Please review before applying

@mywave82
Copy link
Contributor Author

(another minor detail is the OPL3 datasheet says that /IC should be held low for atleast 80 clock cycles)

@ReimuNotMoe ReimuNotMoe merged commit 6480947 into SudoMaker:master Jul 6, 2023
2 checks passed
@ReimuNotMoe
Copy link
Member

Many thanks! We will fix this problem in the firmware of RWOPL3 Express as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants