MINOR: Fix Redshift DBT Playwright (open-metadata#18642)

SumanMaharana · Nov 14, 2024 · 8104c3a · 8104c3a
1 parent 976ad98
commit 8104c3a
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 17 deletions.
diff --git a/openmetadata-ui/src/main/resources/ui/playwright/constant/service.ts b/openmetadata-ui/src/main/resources/ui/playwright/constant/service.ts
@@ -90,17 +90,11 @@ export const POSTGRES = {
 
 export const MYSQL = 'Mysql';
 
-export const HTTP_CONFIG_SOURCE = {
-  DBT_CATALOG_HTTP_PATH:
-    'https://raw.githubusercontent.com/OnkarVO7/dbt_git_test/dbt_aut/catalog.json',
-  DBT_MANIFEST_HTTP_PATH:
-    'https://raw.githubusercontent.com/OnkarVO7/dbt_git_test/dbt_aut/manifest.json',
-  DBT_RUN_RESULTS_FILE_PATH:
-    'https://raw.githubusercontent.com/OnkarVO7/dbt_git_test/dbt_aut/run_results.json',
-};
-
 export const DBT = {
   classification: 'dbtTags',
+  awsRegion: 'us-east-2',
+  s3BucketName: 'awsdatalake-testing',
+  s3Prefix: 'dbt-testing/mayur/',
   tagName: 'model_tag_two',
   dbtQuery: 'select * from "dev"."dbt_automate_upgrade_tests"."stg_orders"',
   dbtLineageNodeLabel: 'customers',

diff --git a/...rc/main/resources/ui/playwright/support/entity/ingestion/RedshiftWithDBTIngestionClass.ts b/...rc/main/resources/ui/playwright/support/entity/ingestion/RedshiftWithDBTIngestionClass.ts
@@ -18,7 +18,7 @@ import {
   PlaywrightWorkerArgs,
   TestType,
 } from '@playwright/test';
-import { DBT, HTTP_CONFIG_SOURCE, REDSHIFT } from '../../../constant/service';
+import { DBT, REDSHIFT } from '../../../constant/service';
 import { SidebarItem } from '../../../constant/sidebar';
 import {
   getApiContext,
@@ -115,19 +115,27 @@ class RedshiftWithDBTIngestionClass extends ServiceBaseClass {
       await page.waitForSelector('#root\\/dbtConfigSource__oneof_select');
       await page.selectOption(
         '#root\\/dbtConfigSource__oneof_select',
-        'DBT HTTP Config'
+        'DBT S3 Config'
       );
       await page.fill(
-        '#root\\/dbtConfigSource\\/dbtCatalogHttpPath',
-        HTTP_CONFIG_SOURCE.DBT_CATALOG_HTTP_PATH
+        '#root\\/dbtConfigSource\\/dbtSecurityConfig\\/awsAccessKeyId',
+        process.env.PLAYWRIGHT_S3_STORAGE_ACCESS_KEY_ID ?? ''
       );
       await page.fill(
-        '#root\\/dbtConfigSource\\/dbtManifestHttpPath',
-        HTTP_CONFIG_SOURCE.DBT_MANIFEST_HTTP_PATH
+        '#root\\/dbtConfigSource\\/dbtSecurityConfig\\/awsSecretAccessKey',
+        process.env.PLAYWRIGHT_S3_STORAGE_SECRET_ACCESS_KEY ?? ''
       );
       await page.fill(
-        '#root\\/dbtConfigSource\\/dbtRunResultsHttpPath',
-        HTTP_CONFIG_SOURCE.DBT_RUN_RESULTS_FILE_PATH
+        '#root\\/dbtConfigSource\\/dbtSecurityConfig\\/awsRegion',
+        DBT.awsRegion
+      );
+      await page.fill(
+        '#root\\/dbtConfigSource\\/dbtPrefixConfig\\/dbtBucketName',
+        DBT.s3BucketName
+      );
+      await page.fill(
+        '#root\\/dbtConfigSource\\/dbtPrefixConfig\\/dbtObjectPrefix',
+        DBT.s3Prefix
       );
 
       await page.click('[data-testid="submit-btn"]');