[step1] 리팩토링 하기 전 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
영상 보고 나서 간단한 부분 리팩토링했습니다. |
bohyunkang
reviewed
Jun 27, 2021
| "image": "../img/pink_s.png" | ||
| }, | ||
| ] | ||
| } |
There was a problem hiding this comment.
지금 마지막에 ⛔ 이러한 이모티콘이 있는 이유는 개행을 하지 않아서인데요,
파일 끝에는 항상 개행을 해야 한다고 하네요!
그렇지 않으면 이 파일이 아직 끝나지 않았다고 인식을 하기 때문인데요,
이거를 EOL(End of Line)이라고 표현하더라고요.
자세한 내용은 참고 링크를 보시고 이해하시면 될 거 같습니다!
참고 링크: https://velog.io/@doondoony/posix-eol
p.s 'prettier' 확장 프로그램을 사용하시면 자동으로 EOL을 해주기 때문에, 'prettier' 사용을 추천드려요~!
bohyunkang
reviewed
Jun 27, 2021
src/main.js
Outdated
|
|
||
| const filterData = (event) => { | ||
| let dataValue = ""; | ||
| const filterData = (event, items) => { |
There was a problem hiding this comment.
함수 표현식이랑 함수 선언문의 차이에 관련된 링크예요!
bohyunkang
reviewed
Jun 27, 2021
src/main.js
Outdated
Comment on lines
16
to
18
| for (let i = 0; i < btn.length; i++) { | ||
| btn[i].addEventListener("click", filterData); | ||
| return items; |
There was a problem hiding this comment.
버블링 캡쳐링 관련된 링크예요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
솔루션 영상 보기 전 결과물입니다.
영상 보고 나서 리팩토링해서 다시 PR 올려볼게요!
📚 프로젝트 진행하면서 배운 점
🕳 프로젝트 진행하면서 만났던 함정