SB-21245 scala script for migrating self-declared user details to con… #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanthoshVasabhaktula
requested changes
Jan 11, 2021
|
|
||
| def migrateSelfDeclaredToConsent()(implicit spark: SparkSession): Unit = { | ||
| var userConsentdDF = spark.read.format("org.apache.spark.sql.cassandra").option("keyspace", "sunbird").option("table", "user_consent").load().persist(StorageLevel.MEMORY_ONLY) | ||
| userConsentdDF = userConsentdDF.where(col("object_type").isin("global", "Organisation")) |
There was a problem hiding this comment.
Do a persist here
There was a problem hiding this comment.
@SanthoshVasabhaktula : done the change
| var userConsentdDF = spark.read.format("org.apache.spark.sql.cassandra").option("keyspace", "sunbird").option("table", "user_consent").load().persist(StorageLevel.MEMORY_ONLY) | ||
| userConsentdDF = userConsentdDF.where(col("object_type").isin("global", "Organisation")) | ||
| println("user_consent data Count : " + userConsentdDF.count()) | ||
| var userDeclaredDF = spark.read.format("org.apache.spark.sql.cassandra").option("keyspace", "sunbird").option("table", "user_declarations").load().persist(StorageLevel.MEMORY_ONLY) |
There was a problem hiding this comment.
Dont use var
There was a problem hiding this comment.
@SanthoshVasabhaktula : setted all DF's as val instead on var's
etl-jobs/src/main/scala/org/sunbird/learner/jobs/SelfDeclarationToConsentMigration.scala
Outdated
Show resolved
Hide resolved
etl-jobs/src/main/scala/org/sunbird/learner/jobs/SelfDeclarationToConsentMigration.scala
Outdated
Show resolved
Hide resolved
etl-jobs/src/main/scala/org/sunbird/learner/jobs/SelfDeclarationToConsentMigration.scala
Show resolved
Hide resolved
SanthoshVasabhaktula
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sent table