taxonomy-editor create term changes #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarishGangula
suggested changes
Feb 6, 2024
README.md
Outdated
| channelId: string, | ||
| authToken: string, | ||
| isApprovalRequired: boolen // set default to false, |
|
@HarishGangula Can you please look into this PR, if any comments missed |
HarishGangula
suggested changes
Feb 9, 2024
| </button> | ||
| </div> | ||
| </div> | ||
| <!-- <button mat-raised-button color="primary" (click)="publishFramwork()">Publish</button> --> |
| app_strings: any = labels; | ||
| constructor(private frameworkService: FrameworkService) { } | ||
|
|
||
| ngOnInit() { |
| ngOnInit() { | ||
| } | ||
|
|
||
| SendForApproval(){ |
There was a problem hiding this comment.
keep code style consistent follow camelcase for method names
| import { ActionBarComponent } from './action-bar.component'; | ||
| import { HttpClientModule } from '@angular/common/http'; | ||
|
|
||
| describe('ActionBarComponent', () => { |
There was a problem hiding this comment.
No test case has proper assertions example: closeActionBar method emits a event but that is not asserted
| </div> | ||
| <div> | ||
| <button mat-raised-button color="primary" (click)="SendForApproval()"> | ||
| {{actionType? getApproveLevelText(configType) :'Send for Approval'}} |
There was a problem hiding this comment.
can we move this logic to ts file
| @@ -0,0 +1,15 @@ | |||
| import { Component, OnInit } from '@angular/core'; | |||
There was a problem hiding this comment.
Delete this component if not used
| console.log('Service...',res) | ||
| this.frameworkCategories = res.result.framework.categories | ||
| }) | ||
| // this.categoriesRepresentations = categoryRepresentationsV1 |
| import { HttpClientModule } from '@angular/common/http'; | ||
| import { MatDialogModule } from '@angular/material/dialog'; | ||
|
|
||
| xdescribe('ConfigFrameworkComponent', () => { |
| <!-- <p>{{data.children.approvalStatus}}, {{data.children.associationProperties?.approvalStatus}}</p> --> | ||
| <!-- *ngIf="!data.isViewOnly && data.children.approvalStatus === 'Draft' && isApprovalRequired" --> | ||
| <div class="term-card-checkbox"> | ||
| <mat-checkbox color="primary" *ngIf="data.children.approvalStatus === 'Draft' && isApprovalRequired && !approvalList.length || |
There was a problem hiding this comment.
Can we move this logic to method in ts and call that method
| @@ -0,0 +1,350 @@ | |||
| import { Component, ElementRef, Input, OnChanges, OnInit, Output, SimpleChanges, ViewChild, EventEmitter, OnDestroy } from '@angular/core'; | |||
There was a problem hiding this comment.
Delete the commented code and unused imports
|
@HarishGangula Changes are pushed, Could you please look into this PR. |
HarishGangula
suggested changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.