Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-deprecated DEF/EQU syntax #43

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

quinnyo
Copy link
Contributor

@quinnyo quinnyo commented Jan 13, 2024

Hi!

This simply prepends DEF to all constant variable definitions found in rgbasm source files.

  • rgbasm 0.7.0 deprecated the 'foo EQU bar' syntax (without the 'DEF')
  • the newer syntax was already being used by hardware.inc
  • 'DEF' has been valid syntax since rgbasm 0.5.0

Hope this is helpful, thanks!

- rgbasm 0.7.0 deprecated constant variable definitions without the 'DEF'
- 'DEF' has been valid syntax since rgbasm 0.5.0
@SuperDisk SuperDisk merged commit 74fa9b7 into SuperDisk:master Jan 13, 2024
1 check passed
@SuperDisk
Copy link
Owner

Thanks! I still don't know the difference between = and EQU though so I'll need to see if maybe that's the preferred way to do it...

@quinnyo
Copy link
Contributor Author

quinnyo commented Jan 13, 2024

I think I can explain that: EQU defines constants, while = is for variable (re)assignment. There's no need to use = if you don't need to change the value.

@SuperDisk
Copy link
Owner

SuperDisk commented Jan 13, 2024

Great, thanks then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants