Skip to content

Commit

Permalink
Merge pull request #98 from acosmicflamingo/minor-improvements
Browse files Browse the repository at this point in the history
Minor improvements
  • Loading branch information
SvenTiigi authored Aug 6, 2024
2 parents 5ade0df + 9592d52 commit 805fe79
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 2 deletions.
5 changes: 4 additions & 1 deletion Sources/HostingView/YouTubePlayerHostingView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ public class YouTubePlayerHostingBaseView: UIView {}
// MARK: - YouTubePlayerHostingView

/// The YouTubePlayer HostingView
@MainActor
public final class YouTubePlayerHostingView: YouTubePlayerHostingBaseView {

// MARK: Properties
Expand Down Expand Up @@ -62,7 +63,9 @@ public final class YouTubePlayerHostingView: YouTubePlayerHostingBaseView {

/// Deinit
deinit {
self.player.pause()
MainActor.assumeIsolated {
self.player.pause()
}
}

}
5 changes: 4 additions & 1 deletion Sources/ViewController/YouTubePlayerViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ public class YouTubePlayerBaseViewController: UIViewController {}
// MARK: - YouTubePlayerViewController

/// The YouTubePlayer ViewController
@MainActor
public final class YouTubePlayerViewController: YouTubePlayerBaseViewController {

// MARK: Properties
Expand Down Expand Up @@ -61,7 +62,9 @@ public final class YouTubePlayerViewController: YouTubePlayerBaseViewController

/// Deinit
deinit {
self.player.pause()
MainActor.assumeIsolated {
self.player.pause()
}
}

// MARK: View-Lifecycle
Expand Down
1 change: 1 addition & 0 deletions Sources/WebView/YouTubePlayerWebView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import WebKit
// MARK: - YouTubePlayerWebView

/// The YouTubePlayer WebView
@MainActor
final class YouTubePlayerWebView: WKWebView {

// MARK: Properties
Expand Down
3 changes: 3 additions & 0 deletions Sources/YouTubePlayer.swift
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import Foundation
// MARK: - YouTubePlayer

/// A YouTubePlayer
@MainActor
public final class YouTubePlayer: ObservableObject {

// MARK: Properties
Expand Down Expand Up @@ -239,6 +240,8 @@ private extension YouTubePlayer {
// Otherwise return out of function
return
}
// Send PlayerState
self.playerStateSubject.send(.ready)
// Send PlaybackState
self.playbackStateSubject.send(playbackState)
case .onPlaybackQualityChange:
Expand Down

0 comments on commit 805fe79

Please sign in to comment.