Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Park MVVM to use current park instead of park location for naming #99

Open
SaturneV opened this issue Nov 13, 2024 · 0 comments
Labels
Refactor 🛠️ Code improvements without changing behavior

Comments

@SaturneV
Copy link
Contributor

Description

Our current implementation of Park MVVM, and more specifically of the logic behind park naming, uses a specific _parkLocation variable that allows us to call an API to obtain the correct park name. However, this park location is already stored in the ViewModel via the _currentPark variable, so it would be simpler to use it directly for this task.

This refactor would allow us to lighten the ViewModel by removing duplicate variables and functions that have the same purpose.

Tasks

  • Remove the _parkLocation variable from the Park ViewModel.
  • Adapt or remove the related Park ViewModel functions.
  • Adapt all the projects files that use the _parkLocation variable
  • Adapt all the projects tests files that use the _parkLocation variable
@SaturneV SaturneV added the Refactor 🛠️ Code improvements without changing behavior label Nov 13, 2024
@SaturneV SaturneV reopened this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor 🛠️ Code improvements without changing behavior
Projects
None yet
Development

No branches or pull requests

2 participants