Feat/Use Nominatim API to display better park names #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaturneV
requested changes
Nov 12, 2024
There was a problem hiding this comment.
Great PR that adds a useful feature! I’ll let you respond to my comments on the general implementation logic of your PR. Don’t forget to check the issues raised by Sonar as well. Also, consider adding more details in the description about the files and components you’ve modified next time. Good job!
app/src/main/java/com/android/streetworkapp/model/park/ParkViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/android/streetworkapp/model/park/ParkNameRepository.kt
Outdated
Show resolved
Hide resolved
|
SaturneV
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Thank you for responding to my comments and for the improvements. After discussion we keep the current implementation and open a non-urgent issue #99 to refactor the Park MVVM in the future. I approve this PR it can be merged. Good job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Until now, we displayed only a placeholder value for the name of each park. The objective of this Pull Request is to change those placeholder names with more meaningful names. To do so, we will display the road of each park by using the Nominatim API.
Features
NominatimParkNameRepositoryto utilise the Nominatim APIHow to Test
Screenshot