Setup online file storage system #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
tercierp
requested changes
Dec 12, 2024
app/src/main/java/com/android/streetworkapp/model/storage/S3StorageClient.kt
Show resolved
Hide resolved
app/src/main/java/com/android/streetworkapp/model/storage/S3StorageClient.kt
Show resolved
Hide resolved
Yep, nothing to test and nothing you can actually do to test as you don't have the keys yet. Will give them Friday on team meeting. |
tercierp
approved these changes
Dec 12, 2024
|
Thank you for your precision approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple S3 wrapper. This allows us to interact with the digital ocean space bucket to save the images from our app.
Note: This needs to get out of the way pretty fast for me to continue on my other pr. There are no tests.
This resolves the issue of not being able to store large images with the free plan of firebase.