Feat/make icon change color in function of nb event #229
Conversation
There was a problem hiding this comment.
Thank you for this Pull Request! In terms of UI, your Pull Request is particularly beautiful and the fact that the color are an echo to the logo is really appreciable. It reinforce the overall coherence of the app. On top of that, we have now an easy way to see the park with a lot of event which is good in terms of UX.
I have a few details that I would like to highlight, but otherwise really good job!
| @@ -222,3 +252,36 @@ fun MarkerInfoWindowContent(park: Park) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| fun gradientColor(startColor: Color, endColor: Color, fraction: Float): Color { | |||
There was a problem hiding this comment.
Docs: the documentation is missing for this function
| return Color(r, g, b, a) | ||
| } | ||
|
|
||
| fun colorToHue(color: Color): Float { |
There was a problem hiding this comment.
Docs: same as the last comment, the documentation is also missing
|
kzepfl
deleted the
feat/make-icon-change-color-in-function-of-nb-event
branch
this PR is a cutdown version of PR #226, where i only keep the functionning functionality
Feature
Icon color will go from : blue (0 event) ==> pink (5+ event)
Changes
MapUi, made so icon change color depending on number of event and 2 helper function for the color gradient of the icongradientColorandcolorToHueChange
variable hotPlaceto change the number of event needed for maximum hotnessTesting
ColorTestin Unite test, map folder. Test the helper function :gradientColorandcolorToHue