Feat/UI to create new events #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at/implement-event-ui
2 tasks
alvaro1080
changed the title
Alex720p
requested changes
Oct 17, 2024
There was a problem hiding this comment.
Really clean code, tests and UI!
However there's a few things that need change:
- modify the naming and place of the constants
review how the events are modified or be clear with the rest of group how we pass events to the composable (i.e by copy if we keep the code like this)Mixed things up, it's not an issue- Change the logo for the time input to remove ambiguities
- Make it so the UI informs the user when an invalid date is used as input
app/src/main/java/com/android/streetworkapp/ui/park/AddEvent.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/android/streetworkapp/ui/park/AddEvent.kt
Outdated
Show resolved
Hide resolved
|
Alex720p
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An UI to create new events
The objective of this pull request is to add a new screen that will be used to create and add a new event to a given park. I tried as much as possible to make sure that the interface is easily usable on a smartphone. This is the reason why a slider is used for the selection of the maximum number of participants of an event. The selection of the date selection is improved to also allow the user to pick a specific hour of the day, since it is important to have a clear hour for the events.
The UI is not totally functional yet, as it will need a viewModel for the parks and one for the events in order to be able to use Firebase. Those viewModels should be available soon.
Features
Objective of the PR
In addition of any improvement you might suggest, I would really appreciate a feedback about the user experience. In particular, do you think that this UI is easily usable on a smartphone? (If anyone could try on a real device, I think it could be useful)
Screenshots
