This repository has been archived by the owner on Mar 24, 2022. It is now read-only.
add container element option for datetimepicker #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, I've had a problem adding the datepicker to an input who as inside a dialog element. In chrome, the datepicker was behind dialog and no z-index could put the datepicker on top
after that I've added an option for the user could choose the element he wants to attach the datepicker making easier to handle such problems. I've added the dialog element as a container and it did work
The body continues to be de default element for attaching the datepicker. One final word about this. Supplying a container option is kind of default for some datepicker libraries like Pikday