Added management of views generation when the files are linked from another project #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synchronization from base
…l classes * Restoring the foundErrors behaviour, pending new argument * Restoring some of the code back
|
Hey Jerome, That's a good idea, but needs a bit of work. I've reverted some of the changes that you had, as one of them broke the model handling code, and the path you added to the tools' project startup didn't exist anywhere except your machine - that shouldn't have been pushed to git :) I've added a folder with a linked view to the sample project, and the code you added doesn't work in this case. Looking further, this looks like it needs a bit of a more complex change to make this work. I'll see if I get some time to help on this |
…elop # Conflicts: # src/R4Mvc.Tools/Commands/GenerateCommand.cs # src/R4Mvc.Tools/Properties/launchSettings.json # src/R4Mvc.Tools/R4Mvc.Tools.csproj
…in R4mvc.generated.cs
… with / such as /Views.
…elop # Conflicts: # src/R4Mvc.Tools/Properties/launchSettings.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ability has been added because we are converting a ASP.NET MVC 5 project working with T4MVC in a new format ASP.NET Core project.
As i use the views/controllers in a LinkBase mechanism, R4MVC was generating the controllers correctly but not the Views.
Additionaly i deactivated in the GenerateCommand (sorry, it was included in the Commit), the foundErrors because we have some nuget packages that are not yet fully compliant in .NET Core, and if we have this, the .generated files are not saved. Perharps, we should add a new setting to apply it ?