generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dwn-sdk-js
to version 0.2.9
#342
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiranCohen
requested review from
frankhinek,
csuwildcat and
mistermoe
as code owners
December 8, 2023 17:43
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
TBDocs Report ✅ No errors or warnings @web5/api
TBDocs Report Updated at 2023-12-20T21:03:29Z |
LiranCohen
force-pushed
the
lirancohen/bump-dwn-sdk-0.2.9
branch
from
December 13, 2023 21:29
76ac45b
to
0676137
Compare
LiranCohen
force-pushed
the
lirancohen/bump-dwn-sdk-0.2.9
branch
from
December 20, 2023 15:49
0676137
to
f48d7a1
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
==========================================
+ Coverage 92.79% 92.95% +0.15%
==========================================
Files 71 71
Lines 16477 16458 -19
Branches 1525 1530 +5
==========================================
+ Hits 15290 15298 +8
+ Misses 1165 1138 -27
Partials 22 22
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we update the
dwn-sdk-js
version to0.2.9
writePrunedRecord
is no longer necessary asdwn-sdk-js
now accepts initialRecordsWrite
messages without any data from any source, not just sync.With
EventLog
now returning amessageCid
cursor, we use an internaluild
watermark to sort the syncOperations.We also now store
setCursor
to represent the last item in the most recentEventGet
request. This way subsequentEventGet
will only bring events beyond the latest one returned from the prior call, adding them to the syncOperations queue.Additionally I've also made sure that the next sync interval does not occur until the prior one has finished. This isn't the optimal way to do this, however in future iterations
sync-manager
will be subscribing to remote nodes in order to get real time events, where an interval sync won't be necessary.For some context but unrelated to this PR: In subsequent PR to
dwn-sdk-js
the cursor will become a an object representing both amessageCid
andsortValue
to use as a cursor point. This prevents specific cases where the messageCid used as a cursor has been deleted.