Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap up ci speedup #356

Merged
merged 6 commits into from
Jan 10, 2024
Merged

wrap up ci speedup #356

merged 6 commits into from
Jan 10, 2024

Conversation

shamilovtim
Copy link
Contributor

@shamilovtim shamilovtim commented Dec 19, 2023

Context

I was monitoring CI performance since #325 got merged and saw one last improvement I could have made which is an additional parallel run. In some cases group B slows down the entire CI run by minutes. By splitting group B, this speeds up CI duration. Furthermore, by putting agent on its own, all runs should perform faster, even when group B is not underperforming.

Implementation

Add group C. CI duration should decrease by about a minute on average.

Results

In some cases now down to 5 min CI runs. About 25% faster than current runs.
Screenshot 2023-12-20 at 12 25 12 AM

Copy link

codesandbox bot commented Dec 19, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
Contributor

github-actions bot commented Dec 19, 2023

TBDocs Report

✅ No errors or warnings

@web5/api

  • Project entry file: packages/api/src/index.ts

TBDocs Report Updated at 2024-01-08T20:19:52Z ab19135

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #356 (ab19135) into main (dbe2708) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #356   +/-   ##
=======================================
  Coverage   91.69%   91.69%           
=======================================
  Files          67       67           
  Lines       18176    18176           
  Branches     1534     1534           
=======================================
  Hits        16667    16667           
  Misses       1487     1487           
  Partials       22       22           
Components Coverage Δ
agent 88.08% <ø> (ø)
api 96.93% <ø> (ø)
common 98.57% <ø> (ø)
credentials ∅ <ø> (∅)
crypto 94.54% <ø> (ø)
dids 92.24% <ø> (ø)
identity-agent 56.81% <ø> (ø)
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 58.43% <ø> (ø)
user-agent 55.22% <ø> (ø)

@shamilovtim
Copy link
Contributor Author

shamilovtim commented Jan 8, 2024

@frankhinek added --workspace packages/crypto-aws-kms to the matrix runner

Copy link
Contributor

@frankhinek frankhinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 Love this!!

This will be helpful when we add more robust testing for sync which may take longer.

@shamilovtim shamilovtim merged commit 77c756d into main Jan 10, 2024
32 checks passed
@shamilovtim shamilovtim deleted the tshamilov/ci-speed-pt2 branch January 10, 2024 19:24
finn-block pushed a commit that referenced this pull request Mar 19, 2024
* final speedup

* alphabetize

* rebalance

* fix bug in cache

* revert
finn-block pushed a commit that referenced this pull request Mar 19, 2024
* final speedup

* alphabetize

* rebalance

* fix bug in cache

* revert
finn-block pushed a commit that referenced this pull request Mar 19, 2024
* final speedup

* alphabetize

* rebalance

* fix bug in cache

* revert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants