Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#11810] Remove archive courses feature #11896

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

[#11810] Remove archive courses feature #11896

wants to merge 21 commits into from

Conversation

daongochieu2810
Copy link
Contributor

Fixes #11810

Outline of Solution

  1. Remove all archive-related features
  2. Add migration script to update the Instructor entity in the datastore

@fsgmhoward fsgmhoward added the s.Ongoing The PR is being worked on by the author(s) label Jul 12, 2022
@daongochieu2810 daongochieu2810 force-pushed the 11810-remove-archive-courses-feature branch from be741f4 to d1f1ff4 Compare July 30, 2022 12:54
@daongochieu2810 daongochieu2810 force-pushed the 11810-remove-archive-courses-feature branch from d1f1ff4 to f469978 Compare July 30, 2022 13:12
@nusoss-bot
Copy link

Guys, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

2 similar comments
@nusoss-bot
Copy link

Guys, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Guys, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@hhdqirui
Copy link
Member

hhdqirui commented Sep 3, 2022

@daongochieu2810 reminder on this PR thanks!

@nusoss-bot
Copy link

Guys, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

1 similar comment
@nusoss-bot
Copy link

Guys, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Guys, This PR seems to be stalling (no activities for the past 23 days). 🐌 😢
Hope someone can get it to move forward again soon...

@zhaojj2209 zhaojj2209 added s.OnHold The issue/PR's validity has been put on hold pending some other event and removed s.Ongoing The PR is being worked on by the author(s) labels Dec 6, 2022
@nusoss-bot
Copy link

Guys, This PR seems to be stalling (no activities for the past 27 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Guys, This PR seems to be stalling (no activities for the past 31 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Guys, This PR seems to be stalling (no activities for the past 34 days). 🐌 😢
Hope someone can get it to move forward again soon...

@wkurniawan07
Copy link
Member

wkurniawan07 commented Apr 4, 2023 •
edited
Loading

@daongochieu2810 can we continue this PR?
I'm yet to look at the changed files, but there is no need to create a migration script for this. Even discounting V9 migration, the isArchived field already present is as good as absent if it is not used anywhere.
There is no need to consider pagination either. A simple feature removal will do for now.

@wkurniawan07 wkurniawan07 added s.Ongoing The PR is being worked on by the author(s) and removed s.OnHold The issue/PR's validity has been put on hold pending some other event labels Apr 4, 2023
@daongochieu2810
Copy link
Contributor Author

@wkurniawan07 yes sure. I'm a bit busy with FYP right now, so I think I can only resume working on this after 19/4, is that ok?

@wkurniawan07
Copy link
Member

@daongochieu2810 no worries there is no rush for this

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

2 similar comments
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@kevin9foong
Copy link
Member

kevin9foong commented Apr 29, 2023 •
edited
Loading

Just checking on this PR as part of regular maintenance activities, any updates on this?

@daongochieu2810
Copy link
Contributor Author

@kevin9foong I will resume working on this next week, sorry for the delay

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

4 similar comments
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@domlimm domlimm added s.OnHold The issue/PR's validity has been put on hold pending some other event s.Ongoing The PR is being worked on by the author(s) and removed s.Ongoing The PR is being worked on by the author(s) s.OnHold The issue/PR's validity has been put on hold pending some other event labels Jun 8, 2023
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

1 similar comment
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 8 days). 🐌 😢
Hope someone can get it to move forward again soon...

@domlimm domlimm added s.OnHold The issue/PR's validity has been put on hold pending some other event and removed s.Ongoing The PR is being worked on by the author(s) labels Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
s.OnHold The issue/PR's validity has been put on hold pending some other event
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove "archive courses" feature
9 participants
@daongochieu2810 @nusoss-bot @hhdqirui @ziqing26 @wkurniawan07 @kevin9foong @fsgmhoward @domlimm @zhaojj2209