Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12588] Improve test coverage of addingQuestionPanelComponent #12632

Closed

Conversation

sdpunit
Copy link

@sdpunit sdpunit commented Oct 28, 2023

Fixes #12588

Outline of Solution

Additional tests to addingQuestionPanelComponent

@github-actions
Copy link

Hi @sdpunit, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

@sdpunit sdpunit changed the title added additional tests [#12588] Improve test coverage of addingQuestionPanelComponent Oct 29, 2023
@sdpunit
Copy link
Author

sdpunit commented Oct 29, 2023

Hey @cedricongjh,

I've submitted a PR to increase the test coverage, but I'm unsure if I've taken the best approach. Could you provide some guidance on how I can ensure better coverage? I feel a bit lost regarding what specific tests or areas would be most beneficial to focus on. Appreciate any feedback or direction you can offer!

@cedricongjh
Copy link
Contributor

cedricongjh commented Oct 30, 2023

hi @sdpunit, as described in the issue #12588, we should first check the codecov for the particular component: https://app.codecov.io/github/TEAMMATES/teammates/blob/master/src%2Fweb%2Fapp%2Fcomponents%2Fadding-question-panel%2Fadding-question-panel.component.ts. Afterwhich, create tests to cover the lines that are currently not being tested.

Do refer to the documentation: https://angular.io/guide/testing-components-scenarios#component-testing-scenarios for the types of tests as well, and refer to other tests that have been written already in the project

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@sdpunit sdpunit closed this Nov 6, 2023
@sdpunit
Copy link
Author

sdpunit commented Nov 6, 2023

I am a bit busy at the moment, will open it again once I finish the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve test code coverage of core components
3 participants