[#12588] Improve test code coverage of core components #13050
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @WayyGood, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
ziqing26
changed the title
|
Hi @WayyGood, thanks for the PR. Please fix the failed Github actions. |
Andy-W-Developer
suggested changes
May 24, 2024
| it('should open modal and set currResponseToAdd when showCommentTableModel is called', () => { | ||
| const selectedResponse: ResponseOutput = { /* mock response */ }; | ||
| const modalResultPromise = new Promise(resolve => resolve()); | ||
| const commentModalRef: NgbModalRef = { |
There was a problem hiding this comment.
Add an import for NgbModelRef
import { NgbModalRef } from '@ng-bootstrap/ng-bootstrap';
| const responseWithoutMissing: ResponseOutput = { isMissingResponse: false }; | ||
| component.responses = [responseWithMissing, responseWithoutMissing]; | ||
|
|
||
| component.filterResponses(); |
There was a problem hiding this comment.
private methods cannot be called from your test
you can call filterResponses() indirectly with ngOnInit() or ngOnChanges() because they both run this.filterResponses()
|
Closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR title: [#12588] Improve test code coverage of core components
(PerQuestionViewResponsesComponent)
Outline of Solution
added testing for some uncovered functions