Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12508] Give respondents a way to reset a rubric question submission #13145

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

NeoHW
Copy link
Contributor

@NeoHW NeoHW commented Jul 14, 2024

Fixes #12508

Outline of Solution

  • Create functionality to give respondents a way to reset the current rubric to an empty state by adding a reset choices button.
  • A confirmation dialogue to ensure respondents want to reset their choices.
  • Add the resetRubricAnswer function to be called after confirmation of the action.

UI changes:
Screenshot 2024-07-15 at 3 13 33 AM

@damithc
Copy link
Contributor

damithc commented Jul 15, 2024

Fixes #12569

@NeoHW #12569 is an abandoned PR. Point to the relevant issue instead.

@domoberzin
Copy link
Contributor

hey @NeoHW, do fix the failing tests before we review the PR, thanks!

@domoberzin domoberzin self-requested a review July 28, 2024 04:11
@domoberzin
Copy link
Contributor

@NeoHW , thanks for the work on this.

I think all other modals appear in the centre of the page. Could you modify yours to appear similarly?

image

Example:
image

@mingyuanc
Copy link
Contributor

@NeoHW any updates?

@NeoHW
Copy link
Contributor Author

NeoHW commented Jul 31, 2024

@domoberzin @mingyuanc , have updated the model accordingly

Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, just a few tiny nits to fix

…rics-question' into ENH/12508/reset-rubrics-question
@NeoHW NeoHW requested a review from domoberzin July 31, 2024 19:06
Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mingyuanc
Copy link
Contributor

@NeoHW pls pass the CI, you can rerun the CI by pressing details and the rerun button is on the top right hand corner

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

1 similar comment
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give respondents a way to reset a rubric question submission
5 participants