Skip to content

Commit

Permalink
Merge pull request #57 from THEOplayer/fix-yospace-types
Browse files Browse the repository at this point in the history
Fix Yospace types
  • Loading branch information
MattiasBuelens authored Nov 5, 2024
2 parents 9931d8d + c1072b8 commit 283c84c
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 17 deletions.
5 changes: 5 additions & 0 deletions .changeset/orange-boxes-fetch.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@theoplayer/yospace-connector-web": patch
---

Require THEOplayer 8.1.0 or higher for correct TypeScript type definitions.
23 changes: 12 additions & 11 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"prettier": "^3.2.4",
"rimraf": "^5.0.5",
"rollup": "^4.14.0",
"theoplayer": "^7.12.0",
"theoplayer": "^8.3.0",
"ts-jest": "^29.1.2",
"ts-node": "^10.9.2",
"tslib": "^2.6.2",
Expand Down
2 changes: 1 addition & 1 deletion typedoc.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"externalDocumentation": {
"theoplayer": {
"dtsPath": "~/THEOplayer.d.ts",
"externalBaseURL": "https://www.theoplayer.com/docs/theoplayer/v7/api-reference/web"
"externalBaseURL": "https://www.theoplayer.com/docs/theoplayer/v8/api-reference/web"
}
}
}
2 changes: 1 addition & 1 deletion yospace/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"package.json"
],
"peerDependencies": {
"theoplayer": "^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0"
"theoplayer": "^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.1.0"
},
"directories": {
"test": "test"
Expand Down
5 changes: 2 additions & 3 deletions yospace/src/integration/YospaceManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@ import type {
ChromelessPlayer,
ServerSideAdIntegrationController,
ServerSideAdIntegrationHandler,
SourceDescription,
YospaceTypedSource
SourceDescription
} from 'theoplayer';
import { getFirstYospaceTypedSource, yoSpaceWebSdkIsAvailable } from '../utils/YospaceUtils';
import { getFirstYospaceTypedSource, type YospaceTypedSource, yoSpaceWebSdkIsAvailable } from '../utils/YospaceUtils';
import { PlayerEvent } from '../yospace/PlayerEvent';
import {
PlaybackMode,
Expand Down

0 comments on commit 283c84c

Please sign in to comment.