Fix error in Conviva type definitions when Yospace is not installed #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, TypeScript users would get the following error when they've installed the Conviva connector without the (optional) Yospace connector dependency:
This PR works around this issue by adding a
@ts-ignore
comment above thatimport
. If the dependency isn't installed, the imported type resolves toany
, which is good enough.Note that we need to use a JSDoc-style comment
/** @ts-ignore */
in order for TypeScript to preserve it during emit. A bit hacky, but it works. 😛