Bugfix/yospace missing ad events #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2ab9fe2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
turbidwater
approved these changes
Oct 30, 2024
|
As this doesn't seem like a true root-cause fix, I've created a followup ticket THEO-10875 to take a deeper look at this later. For now this fix will suffice though! |
GillesMoris-Dolby
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic for creating an AdBreak from the Yospace AdvertStart event, if it is missing. This allows the specific ad events for THEOplayer to be fired.
This solves the case where a viewer joins a stream while an ad is playing, or when a preroll ad plays, but there was no AdvertBreakStart event fired, so the THEOplayer ad events were also missing for this advert break.