Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(radarr): NEW German guide #1993

Open
wants to merge 98 commits into
base: master
Choose a base branch
from
Open

feat(radarr): NEW German guide #1993

wants to merge 98 commits into from
+1,964 −40

Conversation

Lokilicious
Copy link

@Lokilicious Lokilicious commented Jun 29, 2024 •
edited
Loading

Pull Request

Purpose

Initial draft of the new german guide

Requirements

Todos

  • Include the need to merge qualities
  • 1080p x265 ban vs. vector and zerotwo releasing good quality x265
  • Change pictures of merged qualities
  • Change scores of resolutions
  • Add CFs for source (Bluray, Web)
  • Add note for releases where german is the original language where "German" and "German.DL" CF matches
  • Rethink if we need 3 P2P Tiers
  • Add LD/MD CF to unwanted section
  • Find out which groups do which qualities
  • Split up Tier CFs by Quality
  • Adapt Tier CFs to include Quality Conditions
  • Create 1080p and 2160p german booster CF with conditions for resolution and language
  • Adapt scoring to final

@github-actions github-actions bot added Area: Radarr Radarr Related Area: Backend Backend Changes, not related to a specific section Area: Starr Custom Formats Issue is related to custom formats labels Jun 29, 2024
@Lokilicious Lokilicious marked this pull request as ready for review June 29, 2024 10:26
@TRaSH- TRaSH- marked this pull request as draft June 29, 2024 10:55
@Lokilicious Lokilicious force-pushed the feat/Radarr-German-Guide branch from 0a7f53c to a8160d2 Compare July 1, 2024 06:32
@PCJones
Copy link

PCJones commented Jul 16, 2024 •
edited
Loading

Should we add a note/link to the #linemic-dubbed LD/MD CF in the German Audio section or move it to the German Audio section?

(haven't read through the whole thing yet, will do that in ~ 1 week)

@Lokilicious Lokilicious marked this pull request as ready for review December 18, 2024 20:17
@github-actions github-actions bot added the Status: Conflicted Pull Request is Conflicted label Dec 21, 2024
@TRaSH- TRaSH- removed the Status: Conflicted Pull Request is Conflicted label Dec 21, 2024
@github-actions github-actions bot added the Status: Conflicted Pull Request is Conflicted label Dec 21, 2024
@github-actions github-actions bot added the Area: Sonarr Sonarr Related label Dec 22, 2024
@TRaSH- TRaSH- removed the Status: Conflicted Pull Request is Conflicted label Dec 22, 2024
TRaSH-
TRaSH- approved these changes Dec 22, 2024
View reviewed changes
Copy link
Contributor

@TRaSH- TRaSH- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished the last check and all the needed changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakerboy448 bakerboy448 bakerboy448 approved these changes

@TRaSH- TRaSH- TRaSH- approved these changes

Assignees
No one assigned
Labels
Area: Backend Backend Changes, not related to a specific section Area: Radarr Radarr Related Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Lokilicious @PCJones @hexoverflow @m4tz3 @TRaSH- @bakerboy448