-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlueSky fixes (OpenSky, Performance model, wypt speed, MVP) #386
base: master
Are you sure you want to change the base?
Conversation
…ction in the tools and asas directories
… for the traffic cre function.
…culate the limits. When aircraft fly at/near max Mach, the traf.M can be above max Mach due to simulation time step differences, resulting in a Mach limit based on mmo. Even when a reduction of speed is intended based on conflict resolution. This causes the aircraft to get "stuck" at mmo.
…, dependending on input scenario speed (CAS/Mach)
…in each others protected zone. Generally, this behavior is adequately captured by the mvp algorithm, except when one or more ac are at/near their maximum altitude and have no/little room to climb.
…traf.perf.limits function instead of the OpenAP specific limits. Therefore, speed is converted from GS to TAS and the right vertical speed direction is set.
…scarded in aporasas. Another option is to convert the TAS in the MVP back to GS, however, this causes conversion errors that result in loss of separations for aircraft flying (near) max Mach/altitude.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been solved already some time ago in the current master version.
The review request was not intended. However, I can't find any comments specifying "This". |
This referred to the autopilot fixes. It somehow put my reply underneath. |
…ep is discarded in aporasas. Another option is to convert the TAS in the MVP back to GS, however, this causes conversion errors that result in loss of separations for aircraft flying (near) max Mach/altitude." This reverts commit 716e95c.
…nAP) bs.traf.perf.limits function instead of the OpenAP specific limits. Therefore, speed is converted from GS to TAS and the right vertical speed direction is set." This reverts commit ebe4145.
This pull request contains a couple of minor fixes regarding the OpenSky plugin, performance modeling, and waypoint speed interpretation. Furthermore, some larger changes regarding the MVP algorithm are included.