Feature/add hover texts #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OliEfr
reviewed
Jan 16, 2024
|
Thank you very much - that is an awesome improvement! |
|
Merci |
OliEfr
added a commit
that referenced
this pull request
Jan 23, 2024
* fix _execute_action for ff * Fix npm commands (#132) Thanks @A-K-O-R-A for noticing this bug and reporting it! Have a good day. * Feature/add hover texts (#133) * Add hover texts for the popup icons * Extend Informatik discord hover text * Correct spelling * Add OTP support (#131) * Add first classes for otp saving and generation * Typo * OTP saving complete * Better OTP saving * OTP filling * Add recovery codes to prompt * Eslint --------- Co-authored-by: Daniel Kluge <daniel-git@c0ntroller.de> Co-authored-by: Maf <65976562+A-K-O-R-A@users.noreply.github.com> Co-authored-by: Daniel <43993811+C0ntroller@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds title attributes to the shortcut buttons in the popup menu.
References
I created the PR because new users might not be familiar with all services and their icons
Type of change
Testing
We have 1500+ Users. Please test your changes thoroughly.
npm run testlocallyAdditional Information
I also removed the closing
</div>tag on line131as there was no opening tag for it.