Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Typoscript is 1 then PHP is true #64

Merged

Conversation

franzholz
Copy link
Contributor

No description provided.

@franzholz franzholz changed the title Use Typoscript highlight instead of PHP If Typoscript is 1 then PHP is true Jul 23, 2024
Copy link
Contributor

@brotkrueml brotkrueml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I suggest always to use "0" and "1" in TypoScript/TSconfig examples (also default values). "false" is wrong in this context as this evaluates to true.

So, my suggestion: switch from "true" to "1" and "false" to "0".

@garvinhicking
Copy link
Contributor

So, my suggestion: switch from "true" to "1" and "false" to "0".

+true, I mean +1 :-)

@franzholz
Copy link
Contributor Author

This means that TypoScript 1 is on the PHP side true. So this should work as it is in my patch.

@brotkrueml
Copy link
Contributor

This means that TypoScript 1 is on the PHP side true. So this should work as it is in my patch.

Not really, you use this text:

:php:`true` or :typoscript:`1`

This is misleading, as the (unexperienced) user may think, using "true" or "false" is okay (PHP is only shown when hovering over the "true"). My suggestion is, to remove true/false altogether and just use "0" and "1".

Copy link
Contributor

@brotkrueml brotkrueml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me.

@linawolf linawolf merged commit 54d3860 into TYPO3-Documentation:main Jul 28, 2024
1 check passed
@franzholz franzholz deleted the patch-typoscript-highlight branch July 29, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants