-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If Typoscript is 1 then PHP is true #64
If Typoscript is 1 then PHP is true #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I suggest always to use "0" and "1" in TypoScript/TSconfig examples (also default values). "false" is wrong in this context as this evaluates to true.
So, my suggestion: switch from "true" to "1" and "false" to "0".
+true, I mean +1 :-) |
This means that TypoScript 1 is on the PHP side true. So this should work as it is in my patch. |
Not really, you use this text:
This is misleading, as the (unexperienced) user may think, using "true" or "false" is okay (PHP is only shown when hovering over the "true"). My suggestion is, to remove true/false altogether and just use "0" and "1". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for me.
No description provided.