Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CreateModuleWithExtbase.rst #5138

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

Moongazer
Copy link
Contributor

Extend the code example how to create links to Extbase controller actions in modules. It is not obvious based on the current documentation, that the array-key of the new module-configuration must be used, plus passing the controller and action name as arguments.

The issue was solved in Slack (thanks Garvin!) and is now added here for future use.

Extend the code example how to create links to Extbase controller actions. It is not obvious based on the current documentation, that the array-key of the new module-configuration must be used, plus passing the controller and action name as arguments.

The issue was solved in Slack (thanks Garvin!) and is now added here for future use.
Copy link
Contributor

@garvinhicking garvinhicking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be fine by me! Lina, Stefan?

@linawolf linawolf added the backport 13.4 Backport to TYPO3v13 label Dec 11, 2024
@linawolf linawolf self-assigned this Dec 11, 2024
Copy link
Member

@linawolf linawolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Helpfull, thank you!

@linawolf linawolf merged commit 758d8fd into TYPO3-Documentation:12.4 Dec 11, 2024
7 checks passed
Copy link
Contributor

The backport to 13.4 failed:

The process '/usr/bin/git' failed with exit code 1
stderr
error: could not apply f82b9209d... Update CreateModuleWithExtbase.rst
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

stdout
Auto-merging Documentation/ExtensionArchitecture/HowTo/BackendModule/CreateModuleWithExtbase.rst
CONFLICT (content): Merge conflict in Documentation/ExtensionArchitecture/HowTo/BackendModule/CreateModuleWithExtbase.rst

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-13.4 13.4
# Navigate to the new working tree
cd .worktrees/backport-13.4
# Create a new branch
git switch --create backport-5138-to-13.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick f82b9209df1d3a2119d70867a4d41342897aec6a
# Push it to GitHub
git push --set-upstream origin backport-5138-to-13.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-13.4

Then, create a pull request where the base branch is 13.4 and the compare/head branch is backport-5138-to-13.4.

@linawolf
Copy link
Member

Congratulations for your first contribution to this GitHub Organization!

@linawolf linawolf added the backport-required needs cherry-pick into other branches label Dec 11, 2024
linawolf pushed a commit that referenced this pull request Dec 11, 2024
Extend the code example how to create links to Extbase controller actions. It is not obvious based on the current documentation, that the array-key of the new module-configuration must be used, plus passing the controller and action name as arguments.

The issue was solved in Slack (thanks Garvin!) and is now added here for future use.
@linawolf linawolf added backport-done and removed backport-required needs cherry-pick into other branches backport 13.4 Backport to TYPO3v13 backport failed labels Dec 11, 2024
linawolf added a commit that referenced this pull request Dec 11, 2024
Extend the code example how to create links to Extbase controller actions. It is not obvious based on the current documentation, that the array-key of the new module-configuration must be used, plus passing the controller and action name as arguments.

The issue was solved in Slack (thanks Garvin!) and is now added here for future use.

Co-authored-by: Hanns <1685510+moongazer@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
Extend the code example how to create links to Extbase controller actions. It is not obvious based on the current documentation, that the array-key of the new module-configuration must be used, plus passing the controller and action name as arguments.

The issue was solved in Slack (thanks Garvin!) and is now added here for future use.
linawolf pushed a commit that referenced this pull request Dec 11, 2024
Extend the code example how to create links to Extbase controller actions. It is not obvious based on the current documentation, that the array-key of the new module-configuration must be used, plus passing the controller and action name as arguments.

The issue was solved in Slack (thanks Garvin!) and is now added here for future use.

Co-authored-by: Hanns <1685510+moongazer@users.noreply.github.com>
@Moongazer Moongazer deleted the patch-1 branch December 11, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants