-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize RTE page #398
Merged
Merged
Optimize RTE page #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main point it to add examples for setting a preset via page TSconfig. Additionally, the following changes are made: - add a header for the examples (since examples are now extended and this improves finding the examples when skimming the page) - add clarification what "order" (for the presets) means. If not familiar with TYPO3 one might assume, the order means that the later settings overrides the previous which is not the case: once a setting is set, the ones following it are ignored. - clarify what default (number 4. in the listing of "order") means - add some links
brotkrueml
reviewed
Nov 11, 2023
brotkrueml
reviewed
Nov 11, 2023
brotkrueml
reviewed
Nov 11, 2023
brotkrueml
reviewed
Nov 11, 2023
brotkrueml
reviewed
Nov 11, 2023
brotkrueml
reviewed
Nov 11, 2023
brotkrueml
reviewed
Nov 11, 2023
brotkrueml
reviewed
Nov 11, 2023
brotkrueml
reviewed
Nov 11, 2023
brotkrueml
reviewed
Nov 11, 2023
brotkrueml
reviewed
Nov 14, 2023
brotkrueml
approved these changes
Nov 14, 2023
@sypets Thanks for your work 👍 |
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-11.5 11.5
# Navigate to the new working tree
cd .worktrees/backport-11.5
# Create a new branch
git switch --create backport-398-to-11.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick b1e49fb7e10b1603767323a3825e4235c0d24d58,84bd8b85b3d7df14504c4cc7a8ea25ab1172767c,2abaebddcfab65e33338bc84da6c9ae01e371a53,d4917cba94c0b16360a86b562d82b5220163019b,8acaa874f2e476b84957a7d3351fee284a4f1bc7,9849e33e1450b600d5f30ae71813102de6ba2761,062f49e903e40cf68e6c76cf4a38033b34f83d79,5b0b5194838efceec04d61b3d0f5a2545456df66,56824531e9f4909d841dff9a5986f6c1c184c6f2,85c9fa3fde878b2eabcbf9058f1027246373dbcb,d2f9b1b3eca7d48b50edb410c42b2b2f989a115e
# Push it to GitHub
git push --set-upstream origin backport-398-to-11.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-11.5 Then, create a pull request where the |
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-12.4 12.4
# Navigate to the new working tree
cd .worktrees/backport-12.4
# Create a new branch
git switch --create backport-398-to-12.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick b1e49fb7e10b1603767323a3825e4235c0d24d58,84bd8b85b3d7df14504c4cc7a8ea25ab1172767c,2abaebddcfab65e33338bc84da6c9ae01e371a53,d4917cba94c0b16360a86b562d82b5220163019b,8acaa874f2e476b84957a7d3351fee284a4f1bc7,9849e33e1450b600d5f30ae71813102de6ba2761,062f49e903e40cf68e6c76cf4a38033b34f83d79,5b0b5194838efceec04d61b3d0f5a2545456df66,56824531e9f4909d841dff9a5986f6c1c184c6f2,85c9fa3fde878b2eabcbf9058f1027246373dbcb,d2f9b1b3eca7d48b50edb410c42b2b2f989a115e
# Push it to GitHub
git push --set-upstream origin backport-398-to-12.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-12.4 Then, create a pull request where the |
brotkrueml
pushed a commit
to brotkrueml/TYPO3CMS-Reference-TSconfig
that referenced
this pull request
Nov 14, 2023
Main point it to add examples for setting a preset via page TSconfig. Additionally, the following changes are made: - add a header for the examples (since examples are now extended and this improves finding the examples when skimming the page) - add clarification what "order" (for the presets) means. If not familiar with TYPO3 one might assume, the order means that the later settings overrides the previous which is not the case: once a setting is set, the ones following it are ignored. - clarify what default (number 4. in the listing of "order") means - add some links
brotkrueml
added a commit
that referenced
this pull request
Nov 14, 2023
Main point it to add examples for setting a preset via page TSconfig. Additionally, the following changes are made: - add a header for the examples (since examples are now extended and this improves finding the examples when skimming the page) - add clarification what "order" (for the presets) means. If not familiar with TYPO3 one might assume, the order means that the later settings overrides the previous which is not the case: once a setting is set, the ones following it are ignored. - clarify what default (number 4. in the listing of "order") means - add some links Co-authored-by: Sybille Peters <sypets@gmx.de>
brotkrueml
added a commit
to brotkrueml/TYPO3CMS-Reference-TSconfig
that referenced
this pull request
Nov 14, 2023
Main point it to add examples for setting a preset via page TSconfig. Additionally, the following changes are made: - add a header for the examples (since examples are now extended and this improves finding the examples when skimming the page) - add clarification what "order" (for the presets) means. If not familiar with TYPO3 one might assume, the order means that the later settings overrides the previous which is not the case: once a setting is set, the ones following it are ignored. - clarify what default (number 4. in the listing of "order") means - add some links Co-authored-by: Sybille Peters <sypets@gmx.de>
brotkrueml
added a commit
that referenced
this pull request
Nov 14, 2023
Main point it to add examples for setting a preset via page TSconfig. Additionally, the following changes are made: - add a header for the examples (since examples are now extended and this improves finding the examples when skimming the page) - add clarification what "order" (for the presets) means. If not familiar with TYPO3 one might assume, the order means that the later settings overrides the previous which is not the case: once a setting is set, the ones following it are ignored. - clarify what default (number 4. in the listing of "order") means - add some links Co-authored-by: Sybille Peters <sypets@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main point it to add examples for setting a preset via page TSconfig.
Additionally, the following changes are made:
Note to reviewers: