-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Use php-cs-fixer directly #420
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The typo3/coding-standards package isn't compatible with Symfony 7 yet. But as this is only a proxy package for php-cs-fixer defining some rules, we can use php-cs-fixer directly. The configuration from the TYPO3 Core is used. See: https://github.com/TYPO3/typo3/blob/main/Build/php-cs-fixer/config.php Related: TYPO3-Documentation/Changelog-To-Doc#786 Releases: main, 12.4
The PHP minimum version is fixed with #419. |
This was referenced Jan 22, 2024
garvinhicking
approved these changes
Jan 22, 2024
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-12.4 12.4
# Navigate to the new working tree
cd .worktrees/backport-12.4
# Create a new branch
git switch --create backport-420-to-12.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick cdabb54a689cb4fbef4bdb6b4613228197ad4a52
# Push it to GitHub
git push --set-upstream origin backport-420-to-12.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-12.4 Then, create a pull request where the |
brotkrueml
added a commit
to brotkrueml/TYPO3CMS-Reference-TSconfig
that referenced
this pull request
Jan 22, 2024
The typo3/coding-standards package isn't compatible with Symfony 7 yet. But as this is only a proxy package for php-cs-fixer defining some rules, we can use php-cs-fixer directly. The configuration from the TYPO3 Core is used. See: https://github.com/TYPO3/typo3/blob/main/Build/php-cs-fixer/config.php Related: TYPO3-Documentation/Changelog-To-Doc#786 Releases: main, 12.4
brotkrueml
added a commit
that referenced
this pull request
Jan 22, 2024
The typo3/coding-standards package isn't compatible with Symfony 7 yet. But as this is only a proxy package for php-cs-fixer defining some rules, we can use php-cs-fixer directly. The configuration from the TYPO3 Core is used. See: https://github.com/TYPO3/typo3/blob/main/Build/php-cs-fixer/config.php Related: TYPO3-Documentation/Changelog-To-Doc#786 Releases: main, 12.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typo3/coding-standards package isn't compatible with Symfony 7 yet. But as this is only a proxy package for php-cs-fixer defining some rules, we can use php-cs-fixer directly.
The configuration from the TYPO3 Core is used.
See: https://github.com/TYPO3/typo3/blob/main/Build/php-cs-fixer/config.php
Related: TYPO3-Documentation/Changelog-To-Doc#786
Releases: main, 12.4