[TASK] Add plugin.[pluginName].view.defaultPid #697
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linawolf
reviewed
Feb 7, 2023
| "auto" | :t3-data-type:`integer` | ||
|
|
||
| Description | ||
| This can be used to specify a default target page ID. If this value is |
There was a problem hiding this comment.
Suggested change
| This can be used to specify a default target page ID. If this value is | |
| This setting can be used to specify a default target page ID. If this value is |
linawolf
reviewed
Feb 7, 2023
|
|
||
| Description | ||
| This can be used to specify a default target page ID. If this value is | ||
| set, this value will be used as target page ID. If :typoscript:`defaultPid` |
There was a problem hiding this comment.
this value, this value etc. Sounds strange
linawolf
reviewed
Feb 7, 2023
| Description | ||
| This can be used to specify a default target page ID. If this value is | ||
| set, this value will be used as target page ID. If :typoscript:`defaultPid` | ||
| is set to :typoscript:`auto`, a pid is determined by loading the |
There was a problem hiding this comment.
Suggested change
| is set to :typoscript:`auto`, a pid is determined by loading the | |
| is set to :typoscript:`auto`, a PID is determined by loading the |
linawolf
reviewed
Feb 7, 2023
| set, this value will be used as target page ID. If :typoscript:`defaultPid` | ||
| is set to :typoscript:`auto`, a pid is determined by loading the | ||
| :sql:`tt_content` record that contains this plugin. An error will be | ||
| thrown if more than one record matches the :sql:`list_type`. |
There was a problem hiding this comment.
I don't get why we talk about the listtype here suddenly?
|
@brotkrueml are you still working on this one? |
|
can we get this finished today? |
|
@brotkrueml are you still working on this PR? |
|
Nope, will close it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/TYPO3/typo3/blob/main/typo3/sysext/extbase/Classes/Service/ExtensionService.php#L148-L160
Related: TYPO3-Documentation/TYPO3CMS-Reference-CoreApi#2665
Releases: main, 11.5