Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Introduce php:staticmethod directive #10

Merged
merged 1 commit into from
Nov 25, 2023
Merged

[FEATURE] Introduce php:staticmethod directive #10

merged 1 commit into from
Nov 25, 2023

Conversation

linawolf
Copy link
Member

No description provided.

brotkrueml
brotkrueml previously approved these changes Nov 25, 2023
View reviewed changes
Copy link
Contributor

@brotkrueml brotkrueml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add later also an example with php:clasc and staticmethod?

phpstan-baseline.neon Outdated Show resolved Hide resolved
@linawolf
Copy link
Member Author

Yes I will add that test once one of the two directives is merged

@linawolf
Copy link
Member Author

waiting for #13

brotkrueml
brotkrueml previously approved these changes Nov 25, 2023
View reviewed changes
@linawolf
Copy link
Member Author

@brotkrueml added the test with the static method within the class

@linawolf linawolf merged commit 598c70e into main Nov 25, 2023
3 checks passed
@linawolf linawolf deleted the feature/staticmethod branch November 25, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brotkrueml brotkrueml brotkrueml approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linawolf @brotkrueml