[FEATURE] php domain object struct #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linawolf
force-pushed
the
feature/struct
branch
from
b3fc69d
to
cba8f7b
Compare
brotkrueml
reviewed
Dec 9, 2023
There was a problem hiding this comment.
What is meant with "struct"? A DTO? And why it is separated from a old fashioned class? What is the benefit? The Python package does not have it: https://markstory.github.io/sphinxcontrib-phpdomain/reference.html#directives
Personally, I would avoid this. Maybe PHP introduces a "struct" in future versions, than we may have a conflict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.