Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Apply breaking changes of guides to textroles #34

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

linawolf
Copy link
Member

@linawolf linawolf commented Dec 20, 2023

With phpDocumentor/guides#761 the textroles where changed to not rely on the lexer anymore. This makes it necessary to switch to a regex.

The change is necessary so that we can update render-guides to the latest guides version

With phpDocumentor/guides#761 the textroles
where changed to not rely on the lexer anymore. This makes it necessary
to switch to a regex.
Copy link
Contributor

@brotkrueml brotkrueml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, regexes are fun.

@linawolf linawolf merged commit 4cea98e into main Dec 21, 2023
3 checks passed
@linawolf linawolf deleted the task/textroles branch December 21, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants