Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Improve warning for invalid method names #37

Merged
merged 1 commit into from
Mar 2, 2024
Merged

[TASK] Improve warning for invalid method names #37

merged 1 commit into from
Mar 2, 2024

Conversation

linawolf
Copy link
Member

@linawolf linawolf commented Mar 2, 2024

Output context and make more clear we are talking about a method description here

@linawolf
[TASK] Improve warning vor invalid method names
f4a667a 
Output context and make more clear we are talking about a method description here
@brotkrueml
Copy link
Contributor

brotkrueml commented Mar 2, 2024 •
edited
Loading

Can you give more insight, logging output before and after?

@linawolf
Copy link
Member Author

linawolf commented Mar 2, 2024

Before:
app.WARNING: Method signature getImporter is invalid. [] []

After:
app.WARNING: Method signature getImporter in PHP-domain method description is invalid. [file:"somefile.rst", line:"123"] []

The debug output of the context is handed in the guides

@linawolf linawolf merged commit cec5826 into main Mar 2, 2024
3 checks passed
@linawolf linawolf deleted the task/improve-warning branch March 2, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brotkrueml brotkrueml brotkrueml approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linawolf @brotkrueml