[FEATURE] Make Fully Qualified name available in members node. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used to suggest a rst reference snippet in the render-guides. I can then offer the following code in the suggest wizzard: :php:method:`somemanual:\LibraryName\LibraryClassFinal::firstmethod` Instead of something like this: :php:method:`somemanual:libraryname-libraryclassfinal-firstmethod`
Whitespace handling changed in the guides, therefore our integration tests need to be updated for whitespace.
linawolf
added a commit
to TYPO3-Documentation/render-guides
that referenced
this pull request
Mar 24, 2024
For nicer links to members (methods, constants etc) we need TYPO3-Documentation/guides-php-domain#41
There was a problem hiding this comment.
I'm not the biggest trait fan, so just a question that I can better understand the use case here. Why wouldn't we add the method to the SubDirective class? If I saw right, everything that uses the component also inherits from there? And else we might want to create a new "ComponentSubDirective" class if not every SubDirective should receive the method?
|
The Subdirective is in the guides, we cant change it here. We could make another level of inheritance to avoid the trait. My understanding of Traits was, however that they were created to avoid large chains of inheritance.... |
garvinhicking
approved these changes
Mar 24, 2024
linawolf
added a commit
to TYPO3-Documentation/render-guides
that referenced
this pull request
Mar 30, 2024
For nicer links to members (methods, constants etc) we need TYPO3-Documentation/guides-php-domain#41
linawolf
added a commit
to TYPO3-Documentation/render-guides
that referenced
this pull request
Mar 31, 2024
For nicer links to members (methods, constants etc) we need TYPO3-Documentation/guides-php-domain#41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used to suggest a rst reference snippet in the render-guides.
I can then offer the following code in the suggest wizzard:
Instead of something like this:
depends on #42