-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK]: Add all-documentations-menu WebComponent #742
Conversation
@mouflondarko thanks a lot for this solution! We like it very much. I rendered a JSON containting all the manuals here: https://docs.typo3.org/h/typo3/docs-homepage/main/en-us/mainmenu.json Is it possible to use the result of that JSON to render the menu? |
@linawolf sure, the structure looks good and should work as expected. Should the WebComponent fetch this JSON client-side? |
08984b0
to
eb380c4
Compare
@linawolf I've introduced the change in fetching data for the menu, now it should pull current configuration from the url you provided With the current configuration menu looks like this: |
I can also split the output of the System extensions in two for the JSON. that is probably faster then a CSS / JavaScript solution |
See TYPO3-Documentation/DocsTypo3Org-Homepage#259, the columns should look better now |
@linawolf I think it looks good 👍 |
I think so too, what else is needed to make it ready for review? |
@linawolf I think it's ready, would appreciate a feedback |
Looks good, I will merge, make a release and try it out in the wild |
Closes #566
For presentation purposes, all data is mocked as a static JS object