Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Resolve undefined array key warning in FlexFormProcessor #648

Closed
wants to merge 1 commit into from
Closed

[BUGFIX] Resolve undefined array key warning in FlexFormProcessor #648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions Classes/DataProcessing/FlexFormProcessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,16 +99,15 @@ public function process(ContentObjectRenderer $cObj, array $contentObjectConfigu
$fieldName = 'pi_flexform';
}

if (!$processedData['data'][$fieldName] && !$processedData[$fieldName]) {
// processing the flexform data
$originalValue = $processedData['data'][$fieldName] ?? $processedData[$fieldName] ?? null;
if ($originalValue === null) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could add checks for empty string and array, so we can early return and !empty later on will be redundant

return $processedData;
}

// processing the flexform data
$originalValue = $processedData['data'][$fieldName] ?? $processedData[$fieldName];

if (\is_array($originalValue)) {
$flexformData = $originalValue;
} elseif (\is_string($originalValue)) {
} elseif (\is_string($originalValue) && !empty($originalValue)) {
$flexformData = $this->flexFormService->convertFlexFormContentToArray($originalValue);
} else {
return $processedData;
Expand Down