Skip to content

Commit

Permalink
Merge pull request #138 from helhum/prepare-v5-release
Browse files Browse the repository at this point in the history
  • Loading branch information
helhum authored Sep 30, 2022
2 parents 449a6ee + bf09056 commit 7135648
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 9 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ jobs:
fail-fast: false
matrix:
php-versions:
- "7.4"
- "8.0"
- "8.1"
- "8.2"
composer-versions:
Expand Down
7 changes: 2 additions & 5 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"netresearch/composer-installers": "*"
},
"require": {
"php": "^7.4 || ^8.0",
"php": "^8.1",
"composer-plugin-api": "^2.1.0"
},
"require-dev": {
Expand All @@ -47,9 +47,6 @@
"phpunit/phpunit": "^8.5",
"friendsofphp/php-cs-fixer": "^2.18"
},
"conflict": {
"composer/installers": "<2.0.0"
},
"scripts": {
"test:php:lint": [
"phplint"
Expand All @@ -66,7 +63,7 @@
"extra": {
"class": "TYPO3\\CMS\\Composer\\Installer\\Plugin",
"branch-alias": {
"dev-main": "4.0.x-dev"
"dev-main": "5.0.x-dev"
}
}
}
2 changes: 1 addition & 1 deletion src/Plugin/Config.php
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ private static function handleRootPackageExtraConfig(IOInterface $io, RootPackag
$config->merge($rootPackageExtraConfig);
$baseDir = $fileSystem->normalizePath($config->get('base-dir'));
$webDir = $fileSystem->normalizePath($config->get('web-dir'));
if (strpos($webDir, $baseDir) !== 0) {
if (!str_starts_with($webDir, $baseDir)) {
unset($rootPackageExtraConfig['typo3/cms']['web-dir']);
$io->writeError('<warning>TYPO3 public path must be a subdirectory of Composer root directory. Resetting web-dir config to default.</warning>');
}
Expand Down
2 changes: 1 addition & 1 deletion src/Plugin/Util/ExtensionKeyResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class ExtensionKeyResolver
public static function resolve(PackageInterface $package): string
{
$extra = $package->getExtra();
if (empty($extra['typo3/cms']['extension-key']) && strpos($package->getType(), 'typo3-cms-') === 0) {
if (empty($extra['typo3/cms']['extension-key']) && str_starts_with($package->getType(), 'typo3-cms-')) {
// The only reason this is enforced, is to ease the transition of extensions of type "typo3-cms-*"
// Since the logic is removed how to derive the extension key from package name, we must enforce
// the extension key to be set to avoid ambiguity of the extension key between previous installers versions and this one
Expand Down

0 comments on commit 7135648

Please sign in to comment.