Add reserve teams to break. #2498
Conversation
tabbycat/breakqual/base.py
Outdated
| "break_rank": break_rank, | ||
| "remark": ( | ||
| BreakingTeam.REMARK_RESERVE | ||
| if self.break_size < rank <= self.reserve_size + self.break_size |
There was a problem hiding this comment.
x < y < z is neat! I wonder though if we should do something akin to exclude_capped_teams() in aida.py for reserve teams rather than have this logic here.
There was a problem hiding this comment.
I've implemented something along these lines in eed4975, not sure if that's exactly what you had in mind.
tienne-B
force-pushed
the
reserve_break
branch
2 times, most recently
from
47a4ac7
to
082d3d8
Compare
|
Hey @teymour-aldridge ! I've added a commit to clean a few things up using the For AIDA, breaks are capped to a certain number per institution, and this could cause some problems in deciding reserve teams, as a capped reserve may become eligible if the absent team is from their institution. By marking a team as absent though, the break is updated, and could include them, so it shouldn't be a problem. |
tienne-B
force-pushed
the
reserve_break
branch
from
417bc8c
to
e70ae8a
Compare
Thanks! Definitely a lot cleaner :)
👍🏽 |
Also add "absent" remark.
This commit creates a new "add_reserve_teams" method and removes the "create_or_update" remark default and the reserve teams in compute_break as having the same effect. It also consolidates the generated DB migrations, and removes the extraneous "REMARK_" prefix on Remark enum values.
tienne-B
force-pushed
the
reserve_break
branch
from
e70ae8a
to
f58faac
Compare
Should fix #2474.
I'm not sure where the tests (if any) for the debate break generator are – I've just tested this manually using the BP 88 team sample setup. If you could point me to where they are, will add some for this.