Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TCOMP-2506): upgrade avro version to 1.11.x #761

Merged
merged 10 commits into from
Oct 16, 2023

Conversation

wwang-talend
Copy link
Contributor

Requirements

  • Any code change adding any logic MUST be tested through a unit test executed with the default build
  • Any API addition MUST be done with a documentation update if relevant

Why this PR is needed?

https://jira.talendforge.org/browse/TCOMP-2506

What does this PR adds (design/code thoughts)?

https://jira.talendforge.org/browse/TCOMP-2506

@wwang-talend wwang-talend changed the title fix(TCOMP-2506): should not use the removed interface in avro 1.11.x fix(TCOMP-2506): upgrade avro version to 1.11.x Aug 4, 2023
Copy link
Member

@undx undx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions in the PR.
Did you tested the changes against the connectors' repositories? (no pb w/ processingfunc?)

@wwang-talend
Copy link
Contributor Author

lastest pr jenkisn run fail as a random issue, i checked it before, it is a random issue which also happen in master, not about current fix.

@sonar-eks

This comment has been minimized.

@sonar-eks

This comment has been minimized.

@sonar-eks

This comment has been minimized.

@sonar-eks
Copy link

sonar-eks bot commented Oct 16, 2023

Failed

  • 75.61% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 75.61% Coverage (53.80% Estimated after merge)
  • Duplications 0.00% Duplicated Code (1.40% Estimated after merge)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

Copy link
Member

@undx undx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@undx undx merged commit 92bb76a into master Oct 16, 2023
4 of 6 checks passed
@undx undx deleted the wwang-talend/TCOMP-2506-avro branch October 16, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants