-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TCOMP-2506): upgrade avro version to 1.11.x #761
Conversation
b1b0d47
to
ebcfdee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions in the PR.
Did you tested the changes against the connectors' repositories? (no pb w/ processingfunc?)
...e-beam/src/main/java/org/talend/sdk/component/runtime/beam/spi/record/AvroSchemaBuilder.java
Show resolved
Hide resolved
...e-beam/src/main/java/org/talend/sdk/component/runtime/beam/spi/record/AvroSchemaBuilder.java
Show resolved
Hide resolved
lastest pr jenkisn run fail as a random issue, i checked it before, it is a random issue which also happen in master, not about current fix. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Analysis Details0 IssuesCoverage and DuplicationsProject ID: org.talend.sdk.component:component-runtime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Requirements
Why this PR is needed?
https://jira.talendforge.org/browse/TCOMP-2506
What does this PR adds (design/code thoughts)?
https://jira.talendforge.org/browse/TCOMP-2506