Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: convert all packages into internal packages to enable react-fast-refresh on packages/* components #1221

Merged
merged 6 commits into from
Dec 9, 2024
Merged

fix: convert all packages into internal packages to enable react-fast-refresh on packages/* components #1221

merged 6 commits into from
Dec 9, 2024

Conversation

alecdwm
Copy link
Member

@alecdwm alecdwm commented Dec 6, 2024

Includes:

  • Remove unnecessary packages
  • Fix react-fast-refresh in remaining packages

@alecdwm alecdwm temporarily deployed to portal (Preview) December 6, 2024 06:41 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal (Preview) December 6, 2024 06:45 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to talisman-ui (Preview) December 6, 2024 06:48 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal-storybook (Preview) December 6, 2024 06:48 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal (Preview) December 6, 2024 06:54 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal (Preview) December 9, 2024 00:16 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal (Preview) December 9, 2024 00:19 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal-storybook (Preview) December 9, 2024 00:19 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to talisman-ui (Preview) December 9, 2024 00:19 — with GitHub Actions Inactive
@alecdwm alecdwm changed the title feat: redesign fix: convert all packages into internal packages to enable react-fast-refresh on packages/* components Dec 9, 2024
@alecdwm alecdwm requested review from UrbanWill and chidg December 9, 2024 00:49
UrbanWill
UrbanWill approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@UrbanWill UrbanWill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hot reload, noice 🔥

@alecdwm alecdwm enabled auto-merge (squash) December 9, 2024 05:30
@alecdwm alecdwm temporarily deployed to portal (Preview) December 9, 2024 05:31 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal-storybook (Preview) December 9, 2024 05:34 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to talisman-ui (Preview) December 9, 2024 05:34 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal (Preview) December 9, 2024 05:34 — with GitHub Actions Inactive
@alecdwm alecdwm merged commit 4d08305 into main Dec 9, 2024
9 checks passed
@alecdwm alecdwm deleted the feat/redesign branch December 9, 2024 05:37
chidg
chidg approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@chidg chidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UrbanWill UrbanWill UrbanWill approved these changes

@chidg chidg chidg approved these changes

Assignees
No one assigned
Labels
Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alecdwm @chidg @UrbanWill