Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: portal navigation redesign #1228

Merged
merged 13 commits into from
Dec 31, 2024
Merged

feat: portal navigation redesign #1228

merged 13 commits into from
Dec 31, 2024

Conversation

alecdwm
Copy link
Member

@alecdwm alecdwm commented Dec 11, 2024 •
edited
Loading

Implements several design changes to the navigation.

@alecdwm alecdwm added the enhancement New feature or request label Dec 11, 2024
@alecdwm alecdwm self-assigned this Dec 11, 2024
@alecdwm alecdwm temporarily deployed to portal (Preview) December 11, 2024 17:00 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal (Preview) December 11, 2024 23:58 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal (Preview) December 12, 2024 01:01 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to talisman-ui (Preview) December 12, 2024 01:04 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal (Preview) December 12, 2024 01:04 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal-storybook (Preview) December 12, 2024 01:04 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal (Preview) December 12, 2024 01:13 — with GitHub Actions Inactive
@alecdwm alecdwm had a problem deploying to portal-storybook (Preview) December 12, 2024 01:15 — with GitHub Actions Error
@alecdwm alecdwm had a problem deploying to talisman-ui (Preview) December 12, 2024 01:15 — with GitHub Actions Error
@alecdwm alecdwm temporarily deployed to portal (Preview) December 12, 2024 01:17 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to talisman-ui (Preview) December 12, 2024 01:19 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal (Preview) December 12, 2024 01:19 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal-storybook (Preview) December 12, 2024 01:19 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal (Preview) December 23, 2024 20:02 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to talisman-ui (Preview) December 23, 2024 20:04 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal (Preview) December 23, 2024 20:04 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal-storybook (Preview) December 23, 2024 20:04 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal (Preview) December 24, 2024 01:16 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal (Preview) December 24, 2024 01:19 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal-storybook (Preview) December 24, 2024 01:19 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to talisman-ui (Preview) December 24, 2024 01:19 — with GitHub Actions Inactive
@alecdwm alecdwm requested a review from UrbanWill December 30, 2024 01:48
UrbanWill
UrbanWill approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@UrbanWill UrbanWill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey code looks good, I added some minor changes UI in this branch. If you could get them in would be nice: #1240

@UrbanWill
Feat/portal redesign review changes (#1240)
02fd1a9 
* fix: my accounts dropdown icon flex, event types

* fix: added missing Toaster,
did none of our toasts ever work except on SideSheet?

* fix: line height throwing text out of center

* fix: walletConnectionButton layout shift
@alecdwm alecdwm temporarily deployed to portal (Preview) December 31, 2024 05:01 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal (Preview) December 31, 2024 05:03 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to talisman-ui (Preview) December 31, 2024 05:03 — with GitHub Actions Inactive
@alecdwm alecdwm temporarily deployed to portal-storybook (Preview) December 31, 2024 05:03 — with GitHub Actions Inactive
@alecdwm alecdwm merged commit b73baec into main Dec 31, 2024
9 checks passed
@alecdwm alecdwm deleted the feat/portal-redesign branch December 31, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UrbanWill UrbanWill UrbanWill approved these changes

Assignees

@alecdwm alecdwm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alecdwm @UrbanWill