Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump smartstring from 0.2.9 to 1.0.0 #59

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 25, 2022

Bumps smartstring from 0.2.9 to 1.0.0.

Release notes

Sourced from smartstring's releases.

1.0.0

CHANGED

  • smartstring now implements its own boxed string type rather than deferring directly to String, so it no longer makes assumptions it shouldn't be making about the layout of the String struct.

    This also allows us to organise the boxed struct in a way that will let us rely only on our basic assumption that heap memory is word aligned on both big and little endian architectures. The most immediate consequence of this is that smartstring will now compile on 32-bit big endian architectures such as mips.

    We are now also explicitly allocating heap memory aligned for u16 rather than u8, ensuring the assumption about pointer alignment becomes an invariant.

    In short: smartstring no longer relies on undefined behaviour, and should be safe to use anywhere.

  • The above means that the boxed SmartString is no longer pointer compatible with String, so if you were relying on that despite the documentation urging you not to, you'll really have to stop it now. Converting between SmartString and String using From and Into traits is still efficient and allocation free.

  • The minimum supported rustc version is now 1.57.0.

  • The smartstring::validate() function has been removed, as it's no longer needed.

0.2.10

CHANGED

  • The minimum supported rustc version has been increased to 1.56.0, and the rust-version field has been added to the crate's Cargo.toml to indicate the MSRV. (The rust-version field itself was introduced in version 1.56, hence the bump.)
  • Dependencies have been bumped, most notably to arbitrary version 1.
Changelog

Sourced from smartstring's changelog.

[1.0.0] - 2022-02-24

CHANGED

  • smartstring now implements its own boxed string type rather than deferring directly to String, so it no longer makes assumptions it shouldn't be making about the layout of the String struct.

    This also allows us to organise the boxed struct in a way that will let us rely only on our basic assumption that heap memory is word aligned on both big and little endian architectures. The most immediate consequence of this is that smartstring will now compile on 32-bit big endian architectures such as mips.

    We are now also explicitly allocating heap memory aligned for u16 rather than u8, ensuring the assumption about pointer alignment becomes an invariant.

    In short: smartstring no longer relies on undefined behaviour, and should be safe to use anywhere.

  • The above means that the boxed SmartString is no longer pointer compatible with String, so if you were relying on that despite the documentation urging you not to, you'll really have to stop it now. Converting between SmartString and String using From and Into traits is still efficient and allocation free.

  • The minimum supported rustc version is now 1.57.0.

  • The smartstring::validate() function has been removed, as it's no longer needed.

[0.2.10] - 2022-02-20

CHANGED

  • The minimum supported rustc version has been increased to 1.56.0, and the rust-version field has been added to the crate's Cargo.toml to indicate the MSRV. (The rust-version field itself was introduced in version 1.56, hence the bump.)
  • Dependencies have been bumped, most notably to arbitrary version 1.
Commits
  • e3b6d55 (cargo-release) version 1.0.0
  • 65c1d42 Ensure that String pointers are aligned before converting into BoxedString.
  • 7e3a4fc Polish off the docs a bit pre-release.
  • 6e040d0 Fix typos in endian detection.
  • ef3f6f7 Be smarter and less UB about pointer alignment.
  • ec8a93d Don't use a 64 bit integer literal, or tests will break on 32 bit arches.
  • dd4495f Merge pull request #27 from bodil/safe-layout
  • 0b1aa69 Switch the Into impls over to From.
  • ec4d0da Set MSRV to 1.57 so we can panic in const functions.
  • cda37a4 Use a boxed string with a controlled layout to avoid bad assumptions.
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @Tamschi.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [smartstring](https://github.com/bodil/smartstring) from 0.2.9 to 1.0.0.
- [Release notes](https://github.com/bodil/smartstring/releases)
- [Changelog](https://github.com/bodil/smartstring/blob/master/CHANGELOG.md)
- [Commits](bodil/smartstring@v0.2.9...v1.0.0)

---
updated-dependencies:
- dependency-name: smartstring
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from Tamschi as a code owner February 25, 2022 07:18
@dependabot dependabot bot added domain: Rust Involves Rust code. type: upkeep Converting measurements, reorganizing folder structure, and other necessary tasks. labels Feb 25, 2022
Copy link
Owner

@Tamschi Tamschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Auto-Approve Dependabot]
@dependabot merge

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 25, 2022

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 25, 2022

Superseded by #63.

@dependabot dependabot bot closed this Mar 25, 2022
@dependabot dependabot bot deleted the dependabot/cargo/smartstring-1.0.0 branch March 25, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: Rust Involves Rust code. type: upkeep Converting measurements, reorganizing folder structure, and other necessary tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant