-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [FEAT] Allow returning anything in a validator, not just a string #1104
Draft
crutchcorn
wants to merge
38
commits into
main
Choose a base branch
from
return-anything-not-just-string
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9,313
−5,080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View your CI Pipeline Execution ↗ for commit 69c1897.
☁️ Nx Cloud last updated this comment at |
crutchcorn
changed the title
[FIX] Allow returning anything in a validator, not just a string
[WIP] [FIX] Allow returning anything in a validator, not just a string
Jan 9, 2025
This was referenced Jan 9, 2025
crutchcorn
changed the title
[WIP] [FIX] Allow returning anything in a validator, not just a string
[WIP] [FEAT] Allow returning anything in a validator, not just a string
Jan 10, 2025
This was referenced Jan 10, 2025
crutchcorn
force-pushed
the
return-anything-not-just-string
branch
from
January 11, 2025 17:59
20e5b68
to
c9ea6cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows you to return non-string values from validators:
In addition, it also enforces type safety on the returned value on both
errorMap
and theerrors
array:Start Adapter Fixes
Along the way, I wanted to fix the Start adapter, so we're doing so in this PR. Fixes: #1023
Vue typings
This PR also fixes the issues with Vue SFC format and marks Vue 3.4 as the new minimum supported version
TODO
error
array handling