fix(history): browser transitions being skipped for router.history navigation calls

[scarabcoder]

Fixes #2983

When using back(), forward() and go() on router.history for the browser history implementation, native transitions are not occurring.

This is caused by notify() being called twice, once for the back() from the default history implementation and again for when the window event listener is called by the browser for a navigation event.

This PR fixes it by moving calls for notify() to the implementation for the history API, so that the browser history implementation does not call notify() (instead relying on the event subscriber), while the memory implementation calls notify() on every history navigation call.

(fix suggested by @schiller-manuel )

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9155491. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 2 targets

• nx affected --targets=test:eslint,test:unit,test:e2e,test:types,test:build,build --parallel=3
• nx run-many --target=build --exclude=examples/** --exclude=e2e/**

---

Sent with 💌 from NxCloud.

[pkg-pr-new]

Open in Stackblitz

More templates

• tanstack-router-react-example-authenticated-routes
• tanstack-router-react-example-basic
• tanstack-router-react-example-basic-default-search-params
• tanstack-router-react-example-basic-file-based
• tanstack-router-react-example-basic-file-based-codesplitting
• tanstack-router-react-example-react-query
• tanstack-router-react-example-basic-react-query-file-based
• tanstack-router-react-example-basic-ssr-file-based
• tanstack-router-react-example-basic-ssr-streaming-file-based
• tanstack-router-react-example-basic-virtual-file-based
• tanstack-router-react-example-basic-virtual-inside-file-based
• tanstack-router-react-example-deferred-data
• tanstack-router-react-example-kitchen-sink
• tanstack-router-react-example-kitchen-sink-file-based
• tanstack-router-react-example-kitchen-sink-react-query
• tanstack-router-react-example-kitchen-sink-react-query-file-based
• tanstack-router-react-example-large-file-based
• tanstack-router-react-example-location-masking
• tanstack-router-react-example-navigation-blocking
• tanstack-router-react-example-quickstart
• tanstack-router-react-example-quickstart-esbuild-file-based
• tanstack-router-react-example-quickstart-file-based
• tanstack-router-react-example-quickstart-rspack-file-based
• tanstack-router-react-example-quickstart-webpack-file-based
• router-monorepo-react-query
• router-mono-simple
• tanstack-router-react-example-scroll-restoration
• tanstack-search-validator-adapters
• tanstack-start-example-basic
• tanstack-start-example-basic-react-query
• tanstack-start-example-basic-auth
• tanstack-start-example-basic-rsc
• tanstack-start-example-clerk-basic
• tanstack-start-example-convex-trellaux
• tanstack-start-example-large
• tanstack-start-example-counter
• tanstack-start-example-trellaux
• tanstack-start-example-supabase-basic
• tanstack-router-react-example-with-framer-motion
• tanstack-router-react-example-with-trpc
• tanstack-router-react-example-with-trpc-react-query

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@2999

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@2999

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@2999

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@2999

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@2999

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@2999

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@2999

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@2999

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@2999

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@2999

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@2999

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@2999

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@2999

@tanstack/start-vite-plugin

npm i https://pkg.pr.new/@tanstack/start-vite-plugin@2999

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@2999

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@2999

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@2999

commit: 9155491

[schiller-manuel]

we have another PR open that touches history

#1790

this has an ignoreNextPop flag we can use to solve this issue here.
so let's first merge #1790 and then fix the issue here

[ferretwithaberet]

#3017 might fix the same issue, to be checked

Edit: Can you pull the PR above and check if the issue is fixed? @scarabcoder

[schiller-manuel]

yes, #3017 will fix this