Ensure isSubRowSelected returns false if no subRows are selectable

TanStack · Nov 4, 2024 · 2ae44a7 · 2ae44a7
1 parent 82ee099
commit 2ae44a7
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/packages/table-core/src/features/RowSelection.ts b/packages/table-core/src/features/RowSelection.ts
@@ -635,6 +635,7 @@ export function isSubRowSelected<TData extends RowData>(
 
   let allChildrenSelected = true
   let someSelected = false
+  let someSelectable = false
 
   row.subRows.forEach(subRow => {
     // Bail out early if we know both of these
@@ -643,6 +644,7 @@ export function isSubRowSelected<TData extends RowData>(
     }
 
     if (subRow.getCanSelect()) {
+      someSelectable = true
       if (isRowSelected(subRow, selection)) {
         someSelected = true
       } else {
@@ -664,5 +666,7 @@ export function isSubRowSelected<TData extends RowData>(
     }
   })
 
+  if (!someSelectable) return false
+
   return allChildrenSelected ? 'all' : someSelected ? 'some' : false
 }